Sharing an item to the public will appear as successful, but the sharing will revert back to private if using a custom role with the ability to share publicly, and the organizational setting of 'Members can share content publicly' is disabled.
This issue is not reproducible in ArcGIS Online. If the issue occurs, contact Esri Support Services as additional information is required for further investigation.