This is as designed. Pop-ups are static, when configuring popups for the first time, ArcGIS Pro creates the fields list based on the current order of the fields in the table. Any edits done to the field order after that require a manual change in the pop-up configuration pane.